[Mesa-dev] [PATCH] egl: Don't add hardware device if there is no render node v2.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Wed Jun 19 05:27:49 UTC 2019


On Monday, 17 June 2019 19:33:26 CEST Emil Velikov wrote:
> On 2019/06/17, Mathias.Froehlich at gmx.net wrote:
> > From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> > 
> > 
> > Emil,
> > 
> > that one probably matches your original intent then.
> > 
> > please review
> > Thanks
> > 
> > Mathias
> > 
> > 
> > Do not offer a hardware drm backed egl device if no render node
> > is available. The current implementation will fail on this
> > egl device. On top it issues a warning that is actually missleading.
> > There are finally more error paths that can fail on the way to a
> > hardware backed egl device. Fixing all of them would kind of require
> > opening the drm device and see if there is a usable driver associated
> > with the device. The taken approach avoids a full probe and fixes at
> > least this kind of problem on kvm virtualization hosts I observe here.
> > 
> Thanks
> 
> Fixes: dbb4457d985 ("egl: add EGL_EXT_device_drm support")
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks!
Pushed that!

best
Mathias

> 
> -Emil
> 






More information about the mesa-dev mailing list