[Mesa-dev] [PATCH 08/10] panfrost/decode: Remove memory comments

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Wed Jun 19 17:03:34 UTC 2019


These do more harm than good at this point.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
---
 .../drivers/panfrost/pandecode/decode.c       | 20 -------------------
 1 file changed, 20 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c b/src/gallium/drivers/panfrost/pandecode/decode.c
index 2c74d807d63..9b04646f43f 100644
--- a/src/gallium/drivers/panfrost/pandecode/decode.c
+++ b/src/gallium/drivers/panfrost/pandecode/decode.c
@@ -43,12 +43,6 @@ int pandecode_replay_jc(mali_ptr jc_gpu_va, bool bifrost);
 	free(a); \
 }
 
-#define MEMORY_COMMENT(obj, p) {\
-	char *a = pointer_as_memory_reference(obj->p); \
-	pandecode_msg("%s = %s\n", #p, a); \
-	free(a); \
-}
-
 #define DYN_MEMORY_PROP(obj, no, p) { \
 	if (obj->p) \
 		pandecode_prop("%s = %s_%d_p", #p, #p, no); \
@@ -1776,30 +1770,16 @@ pandecode_replay_vertex_tiler_postfix(const struct mali_vertex_tiler_postfix *p,
         pandecode_indent++;
 
         MEMORY_PROP(p, position_varying);
-        MEMORY_COMMENT(p, position_varying);
         DYN_MEMORY_PROP(p, job_no, uniform_buffers);
-        MEMORY_COMMENT(p, uniform_buffers);
         DYN_MEMORY_PROP(p, job_no, texture_trampoline);
-        MEMORY_COMMENT(p, texture_trampoline);
         DYN_MEMORY_PROP(p, job_no, sampler_descriptor);
-        MEMORY_COMMENT(p, sampler_descriptor);
         DYN_MEMORY_PROP(p, job_no, uniforms);
-        MEMORY_COMMENT(p, uniforms);
         DYN_MEMORY_PROP(p, job_no, attributes);
-        MEMORY_COMMENT(p, attributes);
         DYN_MEMORY_PROP(p, job_no, attribute_meta);
-        MEMORY_COMMENT(p, attribute_meta);
         DYN_MEMORY_PROP(p, job_no, varyings);
-        MEMORY_COMMENT(p, varyings);
         DYN_MEMORY_PROP(p, job_no, varying_meta);
-        MEMORY_COMMENT(p, varying_meta);
         DYN_MEMORY_PROP(p, job_no, viewport);
-        MEMORY_COMMENT(p, viewport);
         DYN_MEMORY_PROP(p, job_no, occlusion_counter);
-        MEMORY_COMMENT(p, occlusion_counter);
-        MEMORY_COMMENT(p, framebuffer & ~1);
-        pandecode_msg("%" PRIx64 "\n", p->viewport);
-        pandecode_msg("%" PRIx64 "\n", p->framebuffer);
 
         if (is_bifrost)
                 pandecode_prop("framebuffer = scratchpad_%d_p", job_no);
-- 
2.20.1



More information about the mesa-dev mailing list