[Mesa-dev] [PATCH] panfrost: Set job requirements during draw

[Rohan Garg]

On Thursday, 20 June 2019 16:06:57 CEST you wrote:
> Right now we are doing it at a moment when we don't have all the
> information we need.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> Suggested-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
> Cc: Rohan Garg <rohan.garg at collabora.com>
> Fixes: bfca21b622df ("panfrost: Figure out job requirements in pan_job.c")
> ---
>  src/gallium/drivers/panfrost/pan_context.c | 2 ++
>  src/gallium/drivers/panfrost/pan_job.c     | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
> index 470a259419b6..d33c9331e67d 100644
> --- a/src/gallium/drivers/panfrost/pan_context.c
> +++ b/src/gallium/drivers/panfrost/pan_context.c
> @@ -1056,6 +1056,8 @@ panfrost_emit_for_draw(struct panfrost_context *ctx, bool with_vertex_data)
>                  SET_BIT(ctx->fragment_shader_core.unknown2_4, MALI_NO_MSAA, !msaa);
>          }
>  
> +	panfrost_job_set_requirements(ctx, job);
> +
>          if (ctx->occlusion_query) {
>                  ctx->payload_tiler.gl_enables |= MALI_OCCLUSION_QUERY | MALI_OCCLUSION_PRECISE;
>                  ctx->payload_tiler.postfix.occlusion_counter = ctx->occlusion_query->transfer.gpu;
> diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c
> index 717676021b44..9c5d385e2ef2 100644
> --- a/src/gallium/drivers/panfrost/pan_job.c
> +++ b/src/gallium/drivers/panfrost/pan_job.c
> @@ -90,7 +90,6 @@ panfrost_get_job(struct panfrost_context *ctx,
>  
>          memcpy(&job->key, &key, sizeof(key));
>          _mesa_hash_table_insert(ctx->jobs, &job->key, job);
> -        panfrost_job_set_requirements(ctx, job);
>  
>          return job;
>  }
> 

Ack :)

Cheers
Rohan Garg