[Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Fri Jun 21 13:05:11 UTC 2019

> Very nice, this will fix a few tests.

Ah, of course :)

> Good riddance!

To be fair, a lot of that just got moved in with panfrost_job.. :)

> Can we remove now the has_draws arg?

Maaaaaybe? The has_draws arg controls a lot of things beyond just, you
know, having draws. The whole API there needs to be overhauled quite a
bit. So yes, we can remove it, but -after- this is merged. Enough code
is being changed here as it is; we don't need more things to break.

> What's the primary batch? Might warrant an explanation somewhere.

Meh, I was making up terminology as I went. The primary batch being
everything but the FRAGMENT job -- so, the SET_VALUE/VERTEX/TILER jobs
(and later COMPUTE/GEOMETRY/FUSED). I.e. everything that we actually
handle in panfrost_job and the scoreboarding module, rather than just
what we tag on in pan_fragment (which is sort of special cased? not that
you couldn't also scoreboard those but there's no reason to since
there's only ever one in the chain -- so no deps and manual index=1 --
as far as I know?).

> This is excelent work, thanks!

:D Thank you for the review!


has_draws can be addressed later. Do you want me to add a v2 with a
comment explaining what I meant by "primary batch"? Or should we just
merge as-is (while CI is still green :) and add a followup patch later)?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190621/2ad7f647/attachment.sig>

More information about the mesa-dev mailing list