[Mesa-dev] [PATCH] ac: change ac_query_gpu_info() signatures

[Marek Olšák]

On Fri, Jun 21, 2019 at 1:13 PM Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> From: Emil Velikov <emil.velikov at collabora.com>
>
> Currently libdrm_amdgpu provides a typedef of the various handles. While
> the goal was to make those opaque, it effectively became part of the API
>
> To the best of my knowledge there are two ways to have opaque handles:
>  - "typedef void *foo;" - rather messy IMHO
>  - "stuct foo;" and use "struct foo *" through the API
>
> In our case amdgpU_device_handle is used only internally, plus
> respective code is not used or applicable for r300 and r600. Hence  we
> copied the typedef.
>
> Seemingly this will be a problem since a libdrm_amdgpu wants to change
> the API, while not updating the code(?).
>

libdrm_amdgpu can't change the API.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190621/426fe56c/attachment.html>