[Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

[Alyssa Rosenzweig]

Ah-ha, now we're into parts of the stack I can claim to understand! >:)

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

On Tue, Jun 25, 2019 at 06:37:48PM +0200, Boris Brezillon wrote:
> From: Daniel Stone <daniels at collabora.com>
> 
> Add a pipe_screen->set_damage_region() hook to propagate
> set-damage-region requests to the driver, it's then up to the driver to
> decide what to do with this piece of information.
> 
> If the hook is left unassigned, the buffer-damage extension is
> considered unsupported.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
>  src/gallium/include/pipe/p_screen.h   |  7 +++++++
>  src/gallium/state_trackers/dri/dri2.c | 22 ++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h
> index 3f9bad470950..8df12ee4f865 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -464,6 +464,13 @@ struct pipe_screen {
>     bool (*is_parallel_shader_compilation_finished)(struct pipe_screen *screen,
>                                                     void *shader,
>                                                     unsigned shader_type);
> +
> +   /**
> +    * Set damage region.
> +    */
> +   void (*set_damage_region)(struct pipe_screen *screen,
> +                             struct pipe_resource *resource,
> +                             unsigned int nrects, int *rects);
>  };
>  
>  
> diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c
> index 5caaa9deac41..df22e7c41642 100644
> --- a/src/gallium/state_trackers/dri/dri2.c
> +++ b/src/gallium/state_trackers/dri/dri2.c
> @@ -1806,6 +1806,23 @@ static const __DRI2interopExtension dri2InteropExtension = {
>     .export_object = dri2_interop_export_object
>  };
>  
> +/**
> + * \brief the DRI2bufferDamageExtension set_damage_region method
> + */
> +static void
> +dri2_set_damage_region(__DRIdrawable *dPriv, unsigned int nrects, int *rects)
> +{
> +   struct dri_drawable *drawable = dri_drawable(dPriv);
> +   struct pipe_resource *resource = drawable->textures[ST_ATTACHMENT_BACK_LEFT];
> +   struct pipe_screen *screen = resource->screen;
> +
> +   screen->set_damage_region(screen, resource, nrects, rects);
> +}
> +
> +static __DRI2bufferDamageExtension dri2BufferDamageExtension = {
> +   .base = { __DRI2_BUFFER_DAMAGE, 1 },
> +};
> +
>  /**
>   * \brief the DRI2ConfigQueryExtension configQueryb method
>   */
> @@ -1907,6 +1924,7 @@ static const __DRIextension *dri_screen_extensions[] = {
>     &dri2GalliumConfigQueryExtension.base,
>     &dri2ThrottleExtension.base,
>     &dri2FenceExtension.base,
> +   &dri2BufferDamageExtension.base,
>     &dri2InteropExtension.base,
>     &dri2NoErrorExtension.base,
>     &driBlobExtension.base,
> @@ -1922,6 +1940,7 @@ static const __DRIextension *dri_robust_screen_extensions[] = {
>     &dri2ThrottleExtension.base,
>     &dri2FenceExtension.base,
>     &dri2InteropExtension.base,
> +   &dri2BufferDamageExtension.base,
>     &dri2Robustness.base,
>     &dri2NoErrorExtension.base,
>     &driBlobExtension.base,
> @@ -1982,6 +2001,9 @@ dri2_init_screen(__DRIscreen * sPriv)
>        }
>     }
>  
> +   if (pscreen->set_damage_region)
> +      dri2BufferDamageExtension.set_damage_region = dri2_set_damage_region;
> +
>     if (pscreen->get_param(pscreen, PIPE_CAP_DEVICE_RESET_STATUS_QUERY)) {
>        sPriv->extensions = dri_robust_screen_extensions;
>        screen->has_reset_status_query = true;
> -- 
> 2.20.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190626/c858c2cb/attachment.sig>