[Mesa-dev] [PATCH 1/3] panfrost/ci: Remove batching

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Thu Jun 27 13:04:21 UTC 2019


This series is:

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

On Thu, Jun 27, 2019 at 09:10:33AM +0200, Tomeu Vizoso wrote:
> Panfrost has grown and doesn't leak as much as before.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> ---
>  src/gallium/drivers/panfrost/ci/deqp-runner.sh | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> index 33f146d789f0..e389fc484e6e 100644
> --- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> +++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> @@ -2,9 +2,6 @@
>  
>  set -x
>  
> -# To prevent memory leaks from slowing throughput, restart everything between batches
> -BATCH_SIZE=3000
> -
>  DEQP_OPTIONS="--deqp-surface-width=256 --deqp-surface-height=256"
>  DEQP_OPTIONS="$DEQP_OPTIONS --deqp-visibility=hidden"
>  DEQP_OPTIONS="$DEQP_OPTIONS --deqp-log-images=disable"
> @@ -36,8 +33,7 @@ touch /tmp/result.txt
>  tail -f /tmp/result.txt &
>  
>  while [ -s /tmp/case-list.txt ]; do
> -	head -$BATCH_SIZE /tmp/case-list.txt > /tmp/next-batch.txt
> -	./deqp-gles2 $DEQP_OPTIONS --deqp-log-filename=/dev/null --deqp-caselist-file=/tmp/next-batch.txt >> /tmp/result.txt
> +	./deqp-gles2 $DEQP_OPTIONS --deqp-log-filename=/dev/null --deqp-caselist-file=/tmp/case-list.txt >> /tmp/result.txt
>  	if [ $? -ne 0 ]; then
>  		# Continue from the subtest after the failing one
>  		crashed_test=$(grep "Test case" /tmp/result.txt | tail -1 | sed "s/Test case '\(.*\)'\.\./\1/")
> @@ -47,7 +43,6 @@ while [ -s /tmp/case-list.txt ]; do
>  		echo "Test case '$crashed_test'..
>                           Crash"
>  	else
> -		# Consume a whole batch
> -	    sed -i '1,'$BATCH_SIZE'd' /tmp/case-list.txt
> +		break
>  	fi
>  done
> -- 
> 2.20.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190627/aae7f07d/attachment.sig>


More information about the mesa-dev mailing list