[Mesa-dev] [PATCH] anv: destroy descriptor sets when pool gets reset

[Jason Ekstrand]

pushed.

On Mon, Mar 11, 2019 at 3:15 PM Clayton Craft <clayton.a.craft at intel.com>
wrote:

> On Mon, Mar 11, 2019 at 06:33:54PM +0100, Juan A. Suarez Romero wrote:
> >As stated in Vulkan spec:
> >   "Resetting a descriptor pool recycles all of the resources from all
> >    of the descriptor sets allocated from the descriptor pool back to
> >    the descriptor pool, and the descriptor sets are implicitly freed."
> >
> >This fixes dEQP-VK.api.descriptor_pool.*
> >
> >Fixes: 14f6275c92f1 ("anv/descriptor_set: add reference counting for
> descriptor set layouts")
>
> I ran this though CI and these tests are no longer failing. I didn't see
> any
> regressions either.
>
>
> >CC: Tapani Pälli <tapani.palli at intel.com>
> >CC: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> >CC: Jason Ekstrand <jason at jlekstrand.net>
> >---
> > src/intel/vulkan/anv_descriptor_set.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> >diff --git a/src/intel/vulkan/anv_descriptor_set.c
> b/src/intel/vulkan/anv_descriptor_set.c
> >index f293cf469ee..f34a44aefd7 100644
> >--- a/src/intel/vulkan/anv_descriptor_set.c
> >+++ b/src/intel/vulkan/anv_descriptor_set.c
> >@@ -636,6 +636,12 @@ VkResult anv_ResetDescriptorPool(
> >    }
> >
> >    anv_state_stream_finish(&pool->surface_state_stream);
> >+
> >+   list_for_each_entry_safe(struct anv_descriptor_set, set,
> >+                            &pool->desc_sets, pool_link) {
> >+      anv_descriptor_set_destroy(device, pool, set);
> >+   }
> >+
> >    anv_state_stream_init(&pool->surface_state_stream,
> >                          &device->surface_state_pool, 4096);
> >    pool->surface_state_free_list = NULL;
> >--
> >2.20.1
> >
> >_______________________________________________
> >mesa-dev mailing list
> >mesa-dev at lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCAAdFiEEQ9xksAUlQz+rdXJEYJ7sVybntyAFAlyGwb0ACgkQYJ7sVybn
> tyBuBRAAiuXaaivM1CveLa7svwptOOV41hOmvtWWE75ziY0gMPd/p8Ks1sGkN7um
> BYfoAJUnJeMPKR5AblXX/IcmWL5yG/s8vnQu4DTASzDJnwJlcp7zN3qdBMUcMQuY
> 2LD1UhjuWPNUF4MJFAHqQj7t6vBCM1CtqayhjNCghMRqaQRj3GIee+BDfwm1bUzZ
> 1NYF7W83Gd7rK7yzj0Efbx8C4U0yO/PQYq3ddZlCACD/xLEoUgyjf4IwcOIexBtM
> 0kCcb6ucrqhgLBvZhJRewGvuH2+DBIDzvaZ/AhQSKCLCr/O8HqAEY57TPOIlzNbI
> KgKbEqgJY83uuLqx60iW4bfs+ZtYLlh9HFsJKKrQvmXGbw9BlItPBkFsvFJ7kimo
> G6I7q4WAv3gBquTx6+hB4BmINwlHeEKqQU/U01y+95OAzjIg/8IlSB/QfvDDwtYC
> GPm8S+X6MTFUiYfHeatO9loIvAV2libS5LYGozUsYWAhcS6NrjIWQ3rHovcumFG2
> vhJxOn51Krwp+lPYX8D7ysJK8QGfs+v579TQ75cDdH5lb8xpyBI0cJBFA+Ov/LVI
> tyb9xDIsvX9yTrdZo5Bx9ujRdlaU0KkL/BbWlgUu5J3qhlQsk/e6lV+csNt2OvUv
> e4bwsxht2G1RrtQ+v7miBFO/FVuv5GvAtxr546b2x73GranmRUU=
> =fl2b
> -----END PGP SIGNATURE-----
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190311/8e96f40a/attachment-0001.html>