[Mesa-dev] [Bug 110211] If DESTDIR is set to an empty string, the dri drivers are not installed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110211

Dylan Baker <baker.dylan.c at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #9 from Dylan Baker <baker.dylan.c at gmail.com> ---
---
if os.path.isabs(args.libdir):
    destdir=os.environ.get('DESTDIR','')
    if len(destdir) == 0:
        destdir = '/'
    to = os.path.join(destdir, args.libdir[1:])
  else:
...

Don't use len there, len() for testing emptiness is a python antipattern :)

just `if not destdir:`

However, I think doing something like

destdir = os.environ.get('DESTDIR')
to = args.libdir
if destdir
    to = os.path.join(destdir, to)

is probably sufficient.

Just FYI, we don't do patch review in bugzilla, if you'd like to propose a
patch either an MR at gitlab.freedesktop.org/mesa/mesa or a patch sent to
mesa-dev at lists.freedesktop.org is the proper way.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190321/4f060427/attachment-0001.html>