[Mesa-dev] [Bug 110268] enable storageBuffer16BitAccess feature in radv for SI and CIK

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110268

            Bug ID: 110268
           Summary: enable storageBuffer16BitAccess feature in radv for SI
                    and CIK
           Product: Mesa
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Vulkan/radeon
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: shuizhuyuanluo at 126.com
        QA Contact: mesa-dev at lists.freedesktop.org

the VK_KHR_16bit_storage extension is enabled but all features are reported as
FALSE for SI and CIK.

I found those features are only enabled with VI+ in
mesa/src/amd/vulkan/radv_device.c

as contrast, the amdvlk driver support them.

16bit storage support is important for reducing shader bandwidth and gaining
speed boost. (found 20%~50% speedup with the ncnn vulkan nerual network
benchmark)

please consider implementing storageBuffer16BitAccess feature for SI and CIK.

Thanks!


                case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES:
{
                        VkPhysicalDevice16BitStorageFeatures *features =
                            (VkPhysicalDevice16BitStorageFeatures*)ext;
                        bool enabled = pdevice->rad_info.chip_class >= VI;
                        features->storageBuffer16BitAccess = enabled;
                        features->uniformAndStorageBuffer16BitAccess = enabled;
                        features->storagePushConstant16 = enabled;
                        features->storageInputOutput16 = enabled && HAVE_LLVM
>= 0x900;
                        break;
                }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190328/dcbbbcf9/attachment-0001.html>