[Mesa-dev] [PATCH] radv: do not need to force emit the TCS regs on Vega20

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu May 2 15:40:23 UTC 2019


On 5/2/19 5:35 PM, Marek Olšák wrote:
> This bug is only on Vega10 and Raven1.

Yep, I figured after pushing...

I will update the workaround.

Thanks Marek!

>
> Marek
>
> On Wed, May 1, 2019 at 10:10 AM Samuel Pitoiset 
> <samuel.pitoiset at gmail.com <mailto:samuel.pitoiset at gmail.com>> wrote:
>
>     This chip doesn't need the fixup. This fixes a bunch of
>     dEQP-VK.tessellation tests and avoid random GPU hangs.
>
>     Cc: "19.0" <mesa-stable at lists.freedesktop.org
>     <mailto:mesa-stable at lists.freedesktop.org>>
>     Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com
>     <mailto:samuel.pitoiset at gmail.com>>
>     ---
>      src/amd/vulkan/radv_nir_to_llvm.c | 1 +
>      1 file changed, 1 insertion(+)
>
>     diff --git a/src/amd/vulkan/radv_nir_to_llvm.c
>     b/src/amd/vulkan/radv_nir_to_llvm.c
>     index adf158e30e1..b4a19aa2e5d 100644
>     --- a/src/amd/vulkan/radv_nir_to_llvm.c
>     +++ b/src/amd/vulkan/radv_nir_to_llvm.c
>     @@ -3691,6 +3691,7 @@ LLVMModuleRef
>     ac_translate_nir_to_llvm(struct ac_llvm_compiler *ac_llvm,
>                     ac_init_exec_full_mask(&ctx.ac <http://ctx.ac>);
>
>             if (ctx.ac.chip_class == GFX9 &&
>     +           ctx.ac.family != CHIP_VEGA20 &&
>                 shaders[shader_count - 1]->info.stage ==
>     MESA_SHADER_TESS_CTRL)
>                     ac_nir_fixup_ls_hs_input_vgprs(&ctx);
>
>     -- 
>     2.21.0
>
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190502/f017a91a/attachment.html>


More information about the mesa-dev mailing list