[Mesa-dev] possibly incorrect cut-n-paste in ac_llvm_build.c

Marek Olšák maraeo at gmail.com
Wed May 22 21:19:05 UTC 2019


Yes, this looks like a typo.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Wed, May 22, 2019 at 5:10 PM Dave Airlie <airlied at gmail.com> wrote:

> ping? nha? mareko maybe?
>
> Dave.
>
> On Fri, 17 May 2019 at 12:02, Dave Airlie <airlied at gmail.com> wrote:
> >
> > mesa-19.1.0-rc2/src/amd/common/ac_llvm_build.c:4019: copy_paste_error:
> > "result_exclusive" in "ws->result_exclusive" looks like a copy-paste
> > error.
> >
> > +       if (ws->enable_inclusive)
> > +               ws->result_inclusive = ac_build_alu_op(ctx,
> > ws->result_exclusive, ws->src, ws->op);
> > +       if (ws->enable_exclusive)
> > +               ws->result_exclusive = ac_build_alu_op(ctx,
> > ws->result_exclusive, ws->extra, ws->op);
> >
> > Is that right? maybe a comment?
> >
> > Dave.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190522/a0bee7de/attachment.html>


More information about the mesa-dev mailing list