[Mesa-dev] [Bug 111454] Gallium: removal of the manual defining of PIPE_FORMAT values breaks virgl

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111454

--- Comment #7 from Rob Clark <robclark at freedesktop.org> ---
(In reply to Ilia Mirkin from comment #6)
> (In reply to Rob Clark from comment #5)
> > (In reply to Ilia Mirkin from comment #1)
> > > IMO that should just be backed out. PIPE_FORMAT enum values are used in TGSI
> > > code streams.
> > 
> > I think the eventual goal is to unify PIPE_FORMAT_* and MESA_FORMAT_*, so I
> > guess some further shuffling could happen..  do formats encoded in TGSI ever
> > constitute some ABI?
> 
> You can argue it either way. Virgl uses (used?) this, presumably svga does
> too. The format is encoded in the TGSI ops for image declarations, and
> perhaps in the ops themselves too (due to bindless).
> 
> Whether TGSI forms a more permanent ABI or not ... up to us. I see it as a
> strong point of TGSI that it has this fairly stable well-defined wire
> format, but I also don't have the energy to fight it out.

looks like svga does not handle images (yet?).. but it does some amount of
translating the tgsi, so I guess it could remap encoded formats to some stable
over-the-wire format.

But virgl does, and seems to pass the tgsi straight thru.  Which makes me
suspect it is still broken for shaders that use images :-/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190904/c19cb286/attachment.html>