[Mesa-maintainers] Downstream Mesa patches and quirks

Thu Feb 22 15:23:01 UTC 2018

On Tue, Feb 20, 2018 at 02:58:26PM +0000, Emil Velikov wrote:
> Thank you, glad to hear.

Ok. I'll do the ministep approach.;-) A meta/tracker bug for all bugs and one
bug for each issue.

> >> openSuse
> >>  - multiple "never to be upstreamed" patches, shipping exact same
> >> binaries 4 times (split xvmc/vdpau/etc)
> >
> > Sorry for not responding earlier. I have been busy. :-(
> >
> > - n_Define-GLAPIVAR-separate-from-GLAPI.patch:
> >   Add separate definition GLAPIVAR as GLAPI
> >   doesn't have the an 'extern' for some compiler
> >   versions. This is needed for GLw (bsc#970725).
> >  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_Define-GLAPIVAR-separate-from-GLAPI.patch?expand=1
> >  https://bugzilla.suse.com/show_bug.cgi?id=970725
> >
> >  I'm afraid we still need this for ancient 3rd party GLw programs. :-( Egbert?
> >
> Bug report is not publicly accessible.
> 
> There are zero instances of GLAPIVAR on my setup, plus the headers
> with the Nvidia driver do not have it either.
> Hence I would suggest adding the hack in the GLw header(s).

https://bugzilla.suse.com/show_bug.cgi?id=1082297

> > - n_Disable-AMDGPU-GFX9-Vega-on-LLVM-lessthan-6.0.0.patch
> >   * Disable AMDGPU GFX9/Vega with LLVM < 6.0.0.
> >     While it is supported since LLVM 5.0.0, it was not working
> >     correctly (bnc#1075901). Since we do not have the resources to
> >     determine which fixes should be backported and LLVM 6 will be
> >     released relatively soon, disable the support until then. Users
> >     with the card will have working desktop using software
> >     rendering just like they did with LLVM 4.
> >  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_Disable-AMDGPU-GFX9-Vega-on-LLVM-lessthan-6.0.0.patch?expand=1
> >  https://bugzilla.suse.com/show_bug.cgi?id=1075901
> >
> >  Not sure, whether this change would be appreciated upstream in git. Michal?
> >
> Simple steps:
>  - fd.o report already mentions LLVM patches needed
>  - update LLVM package adding ^^, check with user that things works as expected

https://bugzilla.suse.com/show_bug.cgi?id=1082298

> > - n_VDPAU-XVMC-libs-Replace-hardlinks-with-copies.patch
> >   * Since these are packaged separately in (open)SUSE anyway, one can use
> >   * copies as well. This makes debug packages possible again. (bnc #962609)
> >  https://build.opensuse.org/package/view_file/X11:XOrg/Mesa/n_VDPAU-XVMC-libs-Replace-hardlinks-with-copies.patch?expand=1
> >  https://bugzilla.suse.com/show_bug.cgi?id=962609
> >
> >  I'm not aware of a different fix, when splitting vdpau/xvmc to
> >  subpackages. :-(
> >
> Just ship a single mesa-vdpau/etc package? The extra modularity does
> not bring you anything.

https://bugzilla.suse.com/show_bug.cgi?id=1082300

> There are a few patches:
> 
> - u_mesa-python3-only.patch
> The shebang line should not be needed, looks fine otherwise.

https://bugzilla.suse.com/show_bug.cgi?id=1082303

>  - misc Mesa 8.0 patches
> Originally from Redhat/Fedora - yet they no longer carry them. Drop as
> well or upstream?

https://bugzilla.suse.com/show_bug.cgi?id=1082305

>  - u_Fix-crash-in-swrast-when-setting-a-texture-for-a-pix.patch
> Another 8.0 patch - no bugreport or crashlog. Update commit
> message+send or drop?

https://bugzilla.suse.com/show_bug.cgi?id=1082306

>  - u_add_llvm_codegen_dependencies.patch
> Looks ok - need commit message+upstream

https://bugzilla.suse.com/show_bug.cgi?id=1082307

> Last but not least - some .spec nits:
>  - imake - gone for about a decade now.

Still needed for building GL/GLU manual pages originated from an older Xserver
(from 2006).

>  - libudev - not required since Mesa 13.0.0
>  - openssl - not required since Mesa 17.0.0

https://bugzilla.suse.com/show_bug.cgi?id=1082312

>  - autotools (autoconf, automake, libtool) - not needed when using
> release tarballs

Still needed as long as we patch configure.ac (currently in
u_add_llvm_codegen_dependencies.patch). But I noticed, that build fails if you
patch it and don't have aclocal around, so this no longer can happen unnoticed
it seems. Which is good!

>  - third party (bison, flex, python*) - same as above

also https://bugzilla.suse.com/show_bug.cgi?id=1082312

>  - mesa-nouveau3d - work with upstream about the threading issue,
> don't just remove it
> I'll send a patch that might help later on today

Honestly we more or less gave up about stability of nouveau driver. It may
work on some machines or it may freeze sooner or later. So we it at least easy
to get rid of it by splitting it off. At some point we added some famous
locking patches to this driver, which we then noticed were completely broken
and removed them again. SUSE does not have the ressources either to invest in
the development of this driver. Downstream sometimes simply need to face
reality. Sigh.

>  - ncurses-devel - not used by Mesa, assuming LLVM thing - document

https://bugzilla.suse.com/show_bug.cgi?id=1082315

>  - run ldconfig for backend (ICD) drivers is wrong - dri, nine, xvmc,
> vdpau, va, omx, opencl, and vulkan
> dri, nine and omx are fine, the remainder need fixing

https://bugzilla.suse.com/show_bug.cgi?id=1082316

Thanks a lot for your feedback! I'll work on this buglist ASAP!

CU,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------