[Mesa-stable] [PATCH] mapi: explicitly annotate the shared glapi as such

Eric Engestrom eric.engestrom at imgtec.com
Tue Dec 19 16:26:26 UTC 2017


On Tuesday, 2017-12-19 13:31:59 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> slibtool seems to get confused otherwise - producing both shared and
> static library, and even linking the static one.

I don't think it works; EGL still ends up with its own copy:
$ nm libEGL.so | grep _glapi_tls_Dispatch
0000000000000000 D _glapi_tls_Dispatch

> 
> Cc: <mesa-stable at lists.freedesktop.org>
> Cc: Brendan King <Brendan.King at imgtec.com>
> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/mapi/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am
> index 3f8fcc02e55..2d253953462 100644
> --- a/src/mapi/Makefile.am
> +++ b/src/mapi/Makefile.am
> @@ -77,6 +77,7 @@ shared_glapi_libglapi_la_LIBADD = \
>  	$(PTHREAD_LIBS) \
>  	$(SELINUX_LIBS)
>  shared_glapi_libglapi_la_LDFLAGS = \
> +	-shared \
>  	-no-undefined \
>  	$(GC_SECTIONS) \
>  	$(LD_NO_UNDEFINED)
> -- 
> 2.15.0
> 


More information about the mesa-stable mailing list