[Mesa-stable] [PATCH] mapi: explicitly annotate the shared glapi as such

[Emil Velikov]

On 19 December 2017 at 16:26, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Tuesday, 2017-12-19 13:31:59 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> slibtool seems to get confused otherwise - producing both shared and
>> static library, and even linking the static one.
>
> I don't think it works; EGL still ends up with its own copy:
> $ nm libEGL.so | grep _glapi_tls_Dispatch
> 0000000000000000 D _glapi_tls_Dispatch
>
Yay, it's another bug. I'm short on S(libtool) setup atm, so can you
share the following:
 - what libraries (shared and/or static) does S create in
shared/glapi/ - with and w/o this patch
 - linker command line (for libEGL*) w/o either patch and with each
one applied individually?

An alternative solution is to drop the intermediate libEGL_common.
That will be a bit fiddly, so the original patch (with some comments)
might be a nicer first step (+ short and sweet for stable).

-Emil