[Mesa-stable] [Mesa-dev] [PATCH] configure.ac: add missing llvm dependencies to .pc files

[Emil Velikov]

On 25 January 2018 at 09:44, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Wednesday, 2018-01-24 15:10:35 -0500, Chuck Atkins wrote:
>> CC: <mesa-stable at lists.freedesktop.org>
>> Signed-of-by: Chuck Atkins <chuck.atkins at kitware.com>
>> ---
>>  configure.ac | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 7c1fbe0ed1..e1be7b78e4 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -2780,6 +2780,18 @@ if test "x$enable_llvm" = xyes; then
>>              fi
>>          fi
>>      fi
>> +    if test "xenable_glx" != xno; then
>> +        GL_PC_LIB_PRIV="$GL_PC_LIB_PRIV $LLVM_LIBS"
>> +    fi
Should be used only for gallium-xlib based glx, since it embeds the
swr/llvmpipe driver.

>> +    if test "xenable_gles1" = xyes; then
>> +        GLESv1_CM_PC_LIB_PRIV="$GLESv1_CM_PC_LIB_PRIV $LLVM_LIBS"
>> +    fi
>> +    if test "xenable_gles2" = xyes; then
>> +        GLESv2_PC_LIB_PRIV="$GLESv2_PC_LIB_PRIV $LLVM_LIBS"
>> +    fi
There is no LLVM specific code in these - ^^ should not be needed.

>> +    if test "x$enable_osmesa$enable_gallium_osmesa" != xnono; then
>> +        OSMESA_PC_LIB_PRIV="$OSMESA_PC_LIB_PRIV $OSMESA_PC_LIB_PRIV $LLVM_LIBS"
>
> I'm assuming the duplicate `$OSMESA_PC_LIB_PRIV` wasn't intended?
> I don't know enough to actually review this change though.
>
There should be only one OSMESA_PC_LIB_PRIV and only for the
gallium-osmesa. The classic one does not do swr/llvmpipe.
Speaking of which - can we buy you to fold the two osmesa options,
like you did with --enable-glx?

Eric,
These variables have the dependency libs (-lfoo) that the respective
libraries libGL.so/libGLES*so/etc.
Then they are stored in the the .pc Libs.private section - thus anyone
static linking said libraries will reuse it.

-Emil