[Mesa-stable] [Mesa-dev] [PATCH] configure.ac: add missing llvm dependencies to .pc files

[Chuck Atkins]

> Should be used only for gallium-xlib based glx, since it embeds the
> swr/llvmpipe driver.
>
...
...

> There is no LLVM specific code in these - ^^ should not be needed.
>

Correct.  This was initially to address the problem for OSMesa but I
realized it was likely an issue for more than just OSMesa.  After a bit of
debugging I see that I was indeed a bit overzealous on that.  Will fix in
v2.



>
> >> +    if test "x$enable_osmesa$enable_gallium_osmesa" != xnono; then
> >> +        OSMESA_PC_LIB_PRIV="$OSMESA_PC_LIB_PRIV $OSMESA_PC_LIB_PRIV
> $LLVM_LIBS"
> >
> > I'm assuming the duplicate `$OSMESA_PC_LIB_PRIV` wasn't intended?
>

Will fix in v2.



> These variables have the dependency libs (-lfoo) that the respective
> libraries libGL.so/libGLES*so/etc.
> Then they are stored in the the .pc Libs.private section - thus anyone
> static linking said libraries will reuse it.
>

This is inded the use case here: building a static libGL or static
libOSMesa and having proper dependency info available.

I'll push a corrected v2 shortly.

Thanks for the review.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20180125/72d7b06d/attachment.html>