[Mesa-stable] [Mesa-dev] [PATCH] glsl: fix array assignments of a swizzled vector

Ilia Mirkin imirkin at alum.mit.edu
Fri Oct 5 16:59:58 UTC 2018


On Fri, Oct 5, 2018 at 12:55 PM Ian Romanick <idr at freedesktop.org> wrote:
>
> On 10/04/2018 11:25 PM, Ilia Mirkin wrote:
> > This happens in situations where we might do
> >
> >   vec.wzyx[i] = ...
>
> Ouch.
>
> I haven't looked on the piglit list yet, but is there a piglit test for
> this?

Not yet, but will be tonight. The specific WebGL test is actually
problematic because it's [0] (due to loop unrolling) and not [i] --
the latter should work I believe (but if it doesn't, I'll send a
separate fix for it). I'm going to send tests to cover both cases.

Thanks for taking a look!

  -ilia


More information about the mesa-stable mailing list