[PATCH] huawei: enlarge the checking times for ndisstatqry in disconnecting.

Aleksander Morgado aleksander at lanedo.com
Mon Aug 12 00:07:30 PDT 2013


On 10/08/13 11:26, Fangxiaozhi (Franko) wrote:
> In sometimes, the disconnection of NDISDUP will spend more time than 10s.
> So it is better to enlarge the checking times, such as up to 60 times.
> 

I'm not sure we have a suggested max time to handle the disconnection,
like we do for connection; so I guess it's ok to increase it to such a
value.

Also, mot sure how you created the patch, but didn't apply cleanly with
"git am". Anyway, I did the change manually myself and pushed it. Thanks!


> diff --git a/a/plugins/huawei/mm-broadband-bearer-huawei.c b/b/plugins/huawei/mm-broadband-bearer-huawei.c
> index 13499e0..2e1b0b0 100644
> --- a/a/plugins/huawei/mm-broadband-bearer-huawei.c
> +++ b/b/plugins/huawei/mm-broadband-bearer-huawei.c
> @@ -558,7 +558,7 @@ disconnect_3gpp_context_step (Disconnect3gppContext *ctx)
>  
>      case DISCONNECT_3GPP_CONTEXT_STEP_NDISSTATQRY:
>          /* If too many retries (1s of wait between the retries), failed */
> -        if (ctx->check_count > 10) {
> +        if (ctx->check_count > 60) {
>              /* Clear context */
>              ctx->self->priv->disconnect_pending = NULL;
>              g_simple_async_result_set_error (ctx->result,
> 


-- 
Aleksander


More information about the ModemManager-devel mailing list