[PATCH] huawei: enlarge the checking times for ndisstatqry in disconnecting.

Fangxiaozhi (Franko) fangxiaozhi at huawei.com
Mon Aug 12 19:01:06 PDT 2013

Dear Aleksander:

	OK, thank you very much.

	By the way, I do the patch with the following command:
	git diff a b        (a: the directory of the original modemmanager source code
                     b: the directory of the modified modemmanager source code )

	and then the path will be a/a/... and b/b, I don't know it will be this.

	Can you tell me the right command to do the right patch?

	Thank you very much.

Best Regards,
Franko Fang

>-----Original Message-----
>From: Aleksander Morgado [mailto:aleksander at lanedo.com]
>Sent: Monday, August 12, 2013 3:08 PM
>To: Fangxiaozhi (Franko)
>Cc: modemmanager-devel at lists.freedesktop.org; dcbw at redhat.com; Ben
>Chan; Charles Wen (Ping); Heyongquan; Wangwenyi (Aaron)
>Subject: Re: [PATCH] huawei: enlarge the checking times for ndisstatqry in
>On 10/08/13 11:26, Fangxiaozhi (Franko) wrote:
>> In sometimes, the disconnection of NDISDUP will spend more time than 10s.
>> So it is better to enlarge the checking times, such as up to 60 times.
>I'm not sure we have a suggested max time to handle the disconnection, like we
>do for connection; so I guess it's ok to increase it to such a value.
>Also, mot sure how you created the patch, but didn't apply cleanly with "git am".
>Anyway, I did the change manually myself and pushed it. Thanks!
>> diff --git a/a/plugins/huawei/mm-broadband-bearer-huawei.c
>> b/b/plugins/huawei/mm-broadband-bearer-huawei.c
>> index 13499e0..2e1b0b0 100644
>> --- a/a/plugins/huawei/mm-broadband-bearer-huawei.c
>> +++ b/b/plugins/huawei/mm-broadband-bearer-huawei.c
>> @@ -558,7 +558,7 @@ disconnect_3gpp_context_step
>> (Disconnect3gppContext *ctx)
>>          /* If too many retries (1s of wait between the retries), failed */
>> -        if (ctx->check_count > 10) {
>> +        if (ctx->check_count > 60) {
>>              /* Clear context */
>>              ctx->self->priv->disconnect_pending = NULL;
>>              g_simple_async_result_set_error (ctx->result,

More information about the ModemManager-devel mailing list