libmbim doesn't distcheck

[Aleksander Morgado]

On 24/07/13 02:36, Dan Williams wrote:
> Hey,
> 
> Was trying to distcheck libmbim today so I could propose it for Fedora,
> and it fails because the tests try to look for the codegen-ed files in
> $(top_builddir)/libmbim-glib/generated/, but they aren't there, they are
> actually generated in $(top_srcdir)/libmbim-glib/generated/.  Are the
> generated files expected to be DIST-ed, or is the tarball expected to
> re-generate them?  The core error is:
> 
> gcc -DHAVE_CONFIG_H -I. -I../../../libmbim-glib/test -I../..  -pthread
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
> -I/usr/include/gudev-1.0   -I../../.. -I../../../libmbim-glib
> -I../../libmbim-glib -I../../libmbim-glib/generated
> -DLIBMBIM_GLIB_COMPILATION   -Wall -std=gnu89 -g -O2
> -Wmissing-declarations -Wmissing-prototypes
> -Wdeclaration-after-statement -Wstrict-prototypes -fno-strict-aliasing
> -Wno-deprecated-declarations -Wint-to-pointer-cast -Wfloat-equal
> -Wno-unused-parameter -Wno-sign-compare -Wunused-but-set-variable
> -Wundef -Wimplicit-function-declaration -Wpointer-arith -Winit-self
> -Wshadow -Wmissing-include-dirs -Waggregate-return -Wformat-security
> -Werror -MT test_message_parser-test-message-parser.o -MD -MP
> -MF .deps/test_message_parser-test-message-parser.Tpo -c -o
> test_message_parser-test-message-parser.o `test -f
> 'test-message-parser.c' || echo
> '../../../libmbim-glib/test/'`test-message-parser.c
> ../../../libmbim-glib/test/test-message-parser.c:19:32: fatal error:
> mbim-basic-connect.h: No such file or directory
> compilation terminated.
> make[4]: *** [test_message_parser-test-message-parser.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv
> -f .deps/test_fragment-test-fragment.Tpo .deps/test_fragment-test-fragment.Po
> make[4]: Leaving directory
> `/home/dcbw/Development/fdo/libmbim/libmbim-1.5.0/_build/libmbim-glib/test'
> 
> This fails because ../../libmbim-glib/generated (which is actually
> libmbim-1.5.0/_build/libmbim-glib/generated) only contains the compiled
> generated files, but doesn't contain the generated files themselves.
> Those are still in $(top_srcdir)/libmbim-glib/generated/.
> 

Just fixed it. There was a commit in master (not in the last 1.4.0
release) wrongly removing the 'nodist_' prefix for
libmbim_glib_generated_la_SOURCES. I should really take care of running
distcheck whenever I push something that affects the build :) Thanks for
noticing.

Cheers!

-- 
Aleksander