[RFC PATCH] iface-modem: allow reset and factory reset operation in every state

[Aleksander Morgado]

On 27/08/13 23:32, Dan Williams wrote:
>> Is there a reason that we'd like to disallow modem reset/factory reset when the modem is in FAILED state (e.g. SIM missing). It seems like modems should always allow resetting themselves regardless whether the SIM is missing or locked.
> I think the only reason is that many modems implement simple command
> interpreters (Sierra is the best example here, though ZTE is similar)
> where about the only commands allowed are ATI and +CPIN.  Also there's
> an argument to be made that if your phone or data card is locked, then
> somebody shouldn't just be able to plug it in and wipe it.  That
> argument is somewhat tenuous though, since somebody with physical access
> to your card can simply remove it and use their own SIM (unless of
> course the device is provider-locked).
> 
> (it also may be a left-over from before we had a FAILED state?)
> 
> So I'm fine with this, since:
> 
> 1) it's already PolicyKit authenticated if PK is enabled at build time
> 2) the modem will give you an error if it doesn't allow the command
> anyway, which will be returned to the client
> 
> Aleksander, thoughts?

Yes, I'm fine with this as well. Just pushed it to git master.

-- 
Aleksander