[PATCH v2 1/2] bearer: replace mm_bearer_report_disconnection with mm_bearer_report_status

[Ben Chan]

On Fri, Sep 20, 2013 at 10:21 AM, Aleksander Morgado
<aleksander at lanedo.com>wrote:

> On 09/20/2013 05:44 PM, Ben Chan wrote:
> >     >     I do yes. Your Samsung modems are also Icera based, IIRC. Do
> >     you want me
> >     >     to try to do it? Or, otherwise, if you do it I can test it
> >     with those
> >     >     modems.
> >     >
> >     >
> >     > Uploaded patch v3. I'm testing with an Icera Y3400 and a Huawei
> MU736.
> >     >
> >     > As it's not a small change, more testing would be good. Could you
> try
> >     > the patchs with the modems you have? Thanks.
> >
> >     I updated both patches (v4); please take a look at them. Tested both
> >     with an Option/HSO and an Ericsson MBM modem, and seem to work ok.
> >
> >     The new changes are mainly refactoring some of the plugin specific
> >     methods, plus making sure that the generic report_connection_status()
> >     methods in MMBearer and MMBroadbandBearer only expect DISCONNECTED.
> >     Receiving any other state is a programmer error (e.g. a bearer can
> >     specify that it is now connected only during a connection attempt).
> In
> >     other words, each plugin is responsible for handling the connection
> >     status they expect in addition to DISCONNECTED; they may choose to
> >     ignore them or use them to complete an ongoing connection attempt, or
> >     whatever, but it's up to the plugin to do so. Generic implementation
> >     should always handle DISCONNECTED only.
> >
> >     What do you think of these? Can you test them with the Icera and the
> >     Huawei?
> >
> >
> > Thanks. Looking at the v4 patches. Shouldn't
> > MMBroadbandModemHuawei::bearer_report_connection_status() report
> > DISCONNECTING instead of DISCONNECTED? Perhaps we should also keep the
> > comment to explain why DISCONNECTING is chosen instead of DISCONNECTED.
>
> That's done in patch 2/2 if I'm not mistaken.
>

patch 2/2 doesn't seem to modify mm-broadband-modem-huawei.c


> --
> Aleksander
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20130920/dd26781d/attachment.html>