[PATCH] huawei: fix ^ICCID parsing

[Dan Williams]

On Tue, 2013-09-24 at 14:30 -0700, Ben Chan wrote:
> Seems like some modems swap digits in ^ICCID response and some don't.
> We may need to compute the check digit to determine which format to
> use.

Ben and I talked about this yesterday; every Huawei modem I have, from
the E160g (really old) to a new E397 (recent) swaps the digits in the
^ICCID response.  These are all Qualcomm-based devices.

But I think the E3xxx devices are HiSilicon-based devices, not Qualcomm
ones.  Which would mean completely different firmware, and probably a
completely different team, which probably interpreted the ICCID command
specs completely differently (if there were any).  Not sure about the
MU736 though.

Dan

> On Tue, Sep 24, 2013 at 2:04 PM, Ben Chan <benchan at chromium.org> wrote:
> > ^ICCID reports the ICCID without swapping characters.
> > ---
> > Here's what I observed on E3121, E3131, and MU736:
> >
> >   <debug> (ttyUSB0): --> 'AT^ICCID?<CR>'
> >   <debug> (ttyUSB0): <-- '<CR><LF>^ICCID: 8901260463490013584<CR><LF><CR><LF>OK<CR><LF>'
> >
> >   <debug> (ttyUSB0): --> 'AT+CRSM=176,12258,0,0,10<CR>'
> >   <debug> (ttyUSB0): <-- '<CR><LF>+CRSM: 144,0,"981062403694003185F4"<CR><LF><CR><LF>OK<CR><LF>'
> >
> >  plugins/huawei/mm-sim-huawei.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/plugins/huawei/mm-sim-huawei.c b/plugins/huawei/mm-sim-huawei.c
> > index 7963180..55ba839 100644
> > --- a/plugins/huawei/mm-sim-huawei.c
> > +++ b/plugins/huawei/mm-sim-huawei.c
> > @@ -87,8 +87,7 @@ iccid_read_ready (MMBaseModem *modem,
> >      if (!p)
> >          goto error;
> >
> > -    /* Huawei ^ICCID response must be character swapped */
> > -    parsed = mm_3gpp_parse_iccid (p, TRUE, NULL);
> > +    parsed = mm_3gpp_parse_iccid (p, FALSE, NULL);
> >      if (parsed) {
> >          g_simple_async_result_set_op_res_gpointer (simple, parsed, g_free);
> >          g_simple_async_result_complete (simple);
> > --
> > 1.8.4
> >
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel