[PATCH] iface-modem-3gpp: add SubscriptionState property

Aleksander Morgado aleksander at lanedo.com
Sat Sep 28 07:49:44 PDT 2013


On 28/09/13 01:53, Thieu Le wrote:
> This patch adds a new property, SubscriptionState, to
> org.freedesktop.ModemManager1.Modem.Modem3gpp.  The subscription state
> is used to indicate whether an account has been provisioned, and if so,
> whether the account has any data left.
> 
> There will be two subsequent patches that will make use of this new property.
> 
> Change-Id: Ic7af0e111a323bf2e49feae3a819b630ee4d89ed
> ---
>  include/ModemManager-enums.h                       |  17 +++
>  ...g.freedesktop.ModemManager1.Modem.Modem3gpp.xml |  12 ++
>  src/mm-broadband-modem.c                           |   4 +-
>  src/mm-iface-modem-3gpp.c                          | 144 ++++++++++++++++-----
>  src/mm-iface-modem-3gpp.h                          |  28 ++--
>  5 files changed, 159 insertions(+), 46 deletions(-)


Please also update:

 * libmm-glib with the methods needed to access the new property.
 * mmcli to show the property value when showing the modem status info
(e.g. mmcli -m 0).
 * the gtk-doc documentation with the new enum and methods.

Also, I would very much like to see what the actual implementation
behind the interface is... why not send all patches in a series?

-- 
Aleksander


More information about the ModemManager-devel mailing list