[PATCH 1/3] altair-lte: reference the secondary port in DetailedConnectContext

Ben Chan benchan at chromium.org
Mon Jan 6 11:28:41 PST 2014


>
>
>
> The disconnection sequence also references the secondary port; but it
> shouldn't do it as it's not using it for anything.
>
> The 3GPP connection sequence receives the primary port always, plus a
> secondary port if available, and the sequence logic is responsible for
> making sure that the ports that are going to be used during the sequence
> are available (i.e. a reference to them exist).
>
> In the case of the Altair-LTE plugin (actually, in every plugin in which
> use AT commands and a net iface), the best thing to do is to explicitly
> use the primary port as you suggest, i.e. use the _full() version of the
> command where we can specify the port to use when running the connection
> request. Don't g_assert (secondary == NULL), as that doesn't really
> gives us anything.
>

I've submitted a new patch that explicitly uses the primary port. That way,
we don't need to reference or worry about any secondary port.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/modemmanager-devel/attachments/20140106/60206f47/attachment.html>


More information about the ModemManager-devel mailing list