[PATCH] tests: increase timeout for starting ModemManager on test bus

Ben Chan benchan at chromium.org
Fri Oct 3 13:42:49 PDT 2014


The timeout for starting ModemManager on the test bus was 3s, which is
sufficient under normal conditions. However, when running ModemManager
tests on a build infrastructure under a heavy load, we've observed that
the timeout isn't always sufficient and that becomes the source of false
test failures. This patch increases the timeout to 30s, which shouldn't
introduce any unexpected behavior under normnal conditions while
addressing the timeout issue on heavily loaded systems.
---
 plugins/tests/test-fixture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/tests/test-fixture.c b/plugins/tests/test-fixture.c
index 6b10f47..81644ab 100644
--- a/plugins/tests/test-fixture.c
+++ b/plugins/tests/test-fixture.c
@@ -46,7 +46,7 @@ test_fixture_setup (TestFixture *fixture)
                                           NULL, /* inputs */
                                           NULL, /* outputs */
                                           G_DBUS_CALL_FLAGS_NONE,
-                                          3000, /* timeout, ms */
+                                          30000, /* timeout, ms */
                                           NULL, /* cancellable */
                                           &error);
     if (!result)
-- 
2.1.0.rc2.206.gedb03e5



More information about the ModemManager-devel mailing list