[PATCH] tests: increase timeout for starting ModemManager on test bus
Dan Williams
dcbw at redhat.com
Sun Oct 5 13:38:10 PDT 2014
On Fri, 2014-10-03 at 13:42 -0700, Ben Chan wrote:
> The timeout for starting ModemManager on the test bus was 3s, which is
> sufficient under normal conditions. However, when running ModemManager
> tests on a build infrastructure under a heavy load, we've observed that
> the timeout isn't always sufficient and that becomes the source of false
> test failures. This patch increases the timeout to 30s, which shouldn't
> introduce any unexpected behavior under normnal conditions while
> addressing the timeout issue on heavily loaded systems.
Pushed!
Dan
> ---
> plugins/tests/test-fixture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/tests/test-fixture.c b/plugins/tests/test-fixture.c
> index 6b10f47..81644ab 100644
> --- a/plugins/tests/test-fixture.c
> +++ b/plugins/tests/test-fixture.c
> @@ -46,7 +46,7 @@ test_fixture_setup (TestFixture *fixture)
> NULL, /* inputs */
> NULL, /* outputs */
> G_DBUS_CALL_FLAGS_NONE,
> - 3000, /* timeout, ms */
> + 30000, /* timeout, ms */
> NULL, /* cancellable */
> &error);
> if (!result)
More information about the ModemManager-devel
mailing list