[RFC PATCH] base-manager: quiet message about unsupported ports

Aleksander Morgado aleksander at aleksander.es
Mon Mar 9 10:09:29 PDT 2015


On Mon, Mar 9, 2015 at 5:38 PM, Dan Williams <dcbw at redhat.com> wrote:
> This message gets printed for all netdevs and ttys, including most
> machines normal ethernet/Wi-Fi interfaces.  It seems a bit less critical
> than 'warning' level would indicate.
>
> ModemManager[32097]: <warn>  Couldn't find support for device at '/sys/devices/pci0000:00/0000:00:19.0': not supported by any plugin
> ModemManager[32097]: <warn>  Couldn't find support for device at '/sys/devices/pci0000:00/0000:00:1c.1/0000:02:00.0': not supported by any plugin
>

Sure, yes.

For the netdevs I wonder if we could anyway filter all non-usb based
ones. Maybe updating the candidates rules to flag by driver e.g. if
usbnet/sierra/qmi/... The list of usb drivers of possible network
devices that MM can handle is quite short. This would end up ignoring
completely e.g. non-usb eths and Wi-Fis.

> ---
>
> diff --git a/src/mm-base-manager.c b/src/mm-base-manager.c
> index 3b9f34d..fdcd037 100644
> --- a/src/mm-base-manager.c
> +++ b/src/mm-base-manager.c
> @@ -148,7 +148,7 @@ find_device_support_ready (MMPluginManager *plugin_manager,
>      GError *error = NULL;
>
>      if (!mm_plugin_manager_find_device_support_finish (plugin_manager, result, &error)) {
> -        mm_warn ("Couldn't find support for device at '%s': %s",
> +        mm_info ("Couldn't find support for device at '%s': %s",
>                   mm_device_get_path (ctx->device),
>                   error->message);
>          g_error_free (error);
>
>
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel



-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list