[RFC PATCH] base-manager: quiet message about unsupported ports

[Dan Williams]

On Mon, 2015-03-09 at 18:09 +0100, Aleksander Morgado wrote:
> On Mon, Mar 9, 2015 at 5:38 PM, Dan Williams <dcbw at redhat.com> wrote:
> > This message gets printed for all netdevs and ttys, including most
> > machines normal ethernet/Wi-Fi interfaces.  It seems a bit less critical
> > than 'warning' level would indicate.
> >
> > ModemManager[32097]: <warn>  Couldn't find support for device at '/sys/devices/pci0000:00/0000:00:19.0': not supported by any plugin
> > ModemManager[32097]: <warn>  Couldn't find support for device at '/sys/devices/pci0000:00/0000:00:1c.1/0000:02:00.0': not supported by any plugin
> >
> 
> Sure, yes.

Pushed the patch to git master, mm-1-4, and mm-1-2.

> For the netdevs I wonder if we could anyway filter all non-usb based
> ones. Maybe updating the candidates rules to flag by driver e.g. if
> usbnet/sierra/qmi/... The list of usb drivers of possible network
> devices that MM can handle is quite short. This would end up ignoring
> completely e.g. non-usb eths and Wi-Fis.

Yeah, I think most modems are non-PCI at least, while most wifi/eth are
PCI.  There are a couple edge-cases (Nozomi is PCI, while some cheap
laptops used to have built-in USB wifi modules) but those are quite rare
I think.

Dan

> > ---
> >
> > diff --git a/src/mm-base-manager.c b/src/mm-base-manager.c
> > index 3b9f34d..fdcd037 100644
> > --- a/src/mm-base-manager.c
> > +++ b/src/mm-base-manager.c
> > @@ -148,7 +148,7 @@ find_device_support_ready (MMPluginManager *plugin_manager,
> >      GError *error = NULL;
> >
> >      if (!mm_plugin_manager_find_device_support_finish (plugin_manager, result, &error)) {
> > -        mm_warn ("Couldn't find support for device at '%s': %s",
> > +        mm_info ("Couldn't find support for device at '%s': %s",
> >                   mm_device_get_path (ctx->device),
> >                   error->message);
> >          g_error_free (error);
> >
> >
> > _______________________________________________
> > ModemManager-devel mailing list
> > ModemManager-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
> 
> 
>