[PATCH 2/3] telit: add support for Dell VID in Telit plugin

[Aleksander Morgado]

On Wed, Apr 27, 2016 at 4:36 PM, Daniele Palmas <dnlplm at gmail.com> wrote:
> This patch adds support for Dell VID in Telit plugin in order to provide
> Dell branded Telit modems support
> ---

No, we don't want to do that.

We now have a "Dell" plugin for 1.6.x in git master; this plugin has
the VID based filter, and what it does is detect which kind of modem
it is (QMI, MBIM, Ericsson, Novatel or Sierra). What we should do is
to treat the Telit support in the Dell plugin as we do for Sierra and
Novatel. Please check the Dell plugin to see how that goes (basically
just parsing GMI/CGMI output to match the real vendor) :)

>  plugins/telit/mm-plugin-telit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/telit/mm-plugin-telit.c b/plugins/telit/mm-plugin-telit.c
> index d9793d1..e704ad1 100644
> --- a/plugins/telit/mm-plugin-telit.c
> +++ b/plugins/telit/mm-plugin-telit.c
> @@ -354,7 +354,7 @@ mm_plugin_create (void)
>  {
>      static const gchar *subsystems[] = { "tty", NULL };
>      /* Vendors: Telit */
> -    static const guint16 vendor_ids[] = { 0x1bc7, 0 };
> +    static const guint16 vendor_ids[] = { 0x1bc7, 0x413c, 0 };
>      /* Only handle TELIT tagged devices here. */
>      static const gchar *udev_tags[] = {
>          "ID_MM_TELIT_TAGGED",
> --
> 2.8.1
>



-- 
Aleksander
https://aleksander.es