[PATCH 2/3] telit: add support for Dell VID in Telit plugin
Aleksander Morgado
aleksander at aleksander.es
Wed Apr 27 19:20:30 UTC 2016
On Wed, Apr 27, 2016 at 9:04 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> On Wed, Apr 27, 2016 at 4:36 PM, Daniele Palmas <dnlplm at gmail.com> wrote:
>> This patch adds support for Dell VID in Telit plugin in order to provide
>> Dell branded Telit modems support
>> ---
>
> No, we don't want to do that.
>
> We now have a "Dell" plugin for 1.6.x in git master; this plugin has
> the VID based filter, and what it does is detect which kind of modem
> it is (QMI, MBIM, Ericsson, Novatel or Sierra). What we should do is
> to treat the Telit support in the Dell plugin as we do for Sierra and
> Novatel. Please check the Dell plugin to see how that goes (basically
> just parsing GMI/CGMI output to match the real vendor) :)
One of the rationales for this is to try to minimize the amount of
changes required in the different plugins when new Dell-branded
devices appear (we don't want to require new commits for each new
modem VID/PID appearing in the wild). The Dell plugin should be
intelligent enough to decide which manufacturer is really behind the
device. In your case, you could just get the Dell plugin run the Telit
plugin's custom init and create a MMBroadbandModemTelit afterwards.
Maybe there's something that I'm not considering which prevents this
from being possible?
--
Aleksander
https://aleksander.es
More information about the ModemManager-devel
mailing list