[PATCH 1/5] allow optional quotes in +CREG: <stat>, "<lac>", "<ci>" (GSM 07.07 CREG=2 unsolicited) pattern; add testcase for Thuraya XT

[Dan Williams]

On Fri, 2016-02-12 at 10:15 -0600, Dan Williams wrote:
> On Thu, 2016-02-11 at 16:05 +0100, Thomas Sailer wrote:
> > On 02/11/2016 03:25 PM, Aleksander Morgado wrote:
> > > Why not just make the single quote characters optionals? (instead
> > > of 
> > > providing two options, with and without quotes). 
> > 
> > In the quoted case, comma needs to be excluded in the character
> > set,
> > I 
> > think.
> > 
> > Thuraya response is +CREG: 1, "0426", "F0,0F", so if I did it like
> > you 
> > suggested, it would result in 4 parameters: 1, 0426, 0F, F0
> 
> In this case we'll need to adjust the regexes to capture all
> characters
> between the quotes, and then later stip out the internal comma and
> validate that the characters are xdigit.

Nevermind about this part, your patch for this looks OK to me.

> But do you have any idea what "F0,0F" is supposed to mean?  In the
> ETSI
> specs that supposed to be the CI (Cell ID) but for a satphone I have
> no
> idea if it's OK to strip out the comma and return F00F for the
> cellid.

Still curious about this part though.  We probably still want to strip
out the comma, since a 3GPP cellid is numbers only I believe.

Dan