[PATCH 0/1] plugins: telit: add supported modes loading

Dan Williams dcbw at redhat.com
Wed Jan 27 07:18:16 PST 2016


On Tue, 2016-01-26 at 10:03 +0100, Daniele Palmas wrote:
> This patch adds supported modes loading in Telit plugin.
> 
> The patch has basically been written for removing the only AT command
> that
> returns error during the initialization sequence (due to AT*CNTI not
> supported
> by Telit modem).

That error doesn't get printed to logs or returned to the user though,
so is it really a problem?  At least I'm 99.9% sure it doesn't.  And
the generic code tries WS46 right after so it should return the same
result.

> Adding the supported modes loading in Telit plugin gives also the
> possibility
> to extend the functionality for retrieving the preferred mode.

This would probably go into current_modes though, unless I'm mistaken. 
 And since Telit doesn't yet implement the current mode, it would be
great to have that, and it looks like at least the HE/UE 910 support
AT+WS46=<n> to set the current/preferred mode.

Dan

> Daniele Palmas (1):
>   plugins: telit: add supported modes loading
> 
>  plugins/telit/mm-broadband-modem-telit.c | 173
> +++++++++++++++++++++++++++++++
>  1 file changed, 173 insertions(+)
> 


More information about the ModemManager-devel mailing list