[PATCH 0/1] plugins: telit: add supported modes loading

[Daniele Palmas]

Hi Dan,

2016-01-27 16:18 GMT+01:00 Dan Williams <dcbw at redhat.com>:
> On Tue, 2016-01-26 at 10:03 +0100, Daniele Palmas wrote:
>> This patch adds supported modes loading in Telit plugin.
>>
>> The patch has basically been written for removing the only AT command
>> that
>> returns error during the initialization sequence (due to AT*CNTI not
>> supported
>> by Telit modem).
>
> That error doesn't get printed to logs or returned to the user though,
> so is it really a problem?  At least I'm 99.9% sure it doesn't.  And
> the generic code tries WS46 right after so it should return the same
> result.

You are right, the error is seen only in debug (when dumping also the
AT command) and exactly returns the same result.

I don't have any problem with this "error", but sometimes customers
are scared when they blindly look for the 'error" keyword and find
it...

Anyway, if you don't think it is worth, please drop the patch.

>
>> Adding the supported modes loading in Telit plugin gives also the
>> possibility
>> to extend the functionality for retrieving the preferred mode.
>
> This would probably go into current_modes though, unless I'm mistaken.
>  And since Telit doesn't yet implement the current mode, it would be
> great to have that, and it looks like at least the HE/UE 910 support
> AT+WS46=<n> to set the current/preferred mode.

Yeah, I will take a look at that.

Thanks,
Daniele

>
> Dan
>
>> Daniele Palmas (1):
>>   plugins: telit: add supported modes loading
>>
>>  plugins/telit/mm-broadband-modem-telit.c | 173
>> +++++++++++++++++++++++++++++++
>>  1 file changed, 173 insertions(+)
>>