mm_iface_modem_is_cdma_only

Wed Jul 20 06:05:22 UTC 2016

On Wed, Jul 20, 2016 at 1:11 AM, matthew stanger <stangerm2 at gmail.com> wrote:
> I was just finishing up a patch for swwan support in the Cinterion plugin.
> During my testing I noticed that with the PLS8-X & no SIM card inserted
> mmcli gives a timeout error instead of a no-sim error. I traced it back to
> 'mm-inface-modem.c' where there is a bitwise operation:
> return !((MM_MODEM_CAPABILITY_CDMA_EVDO ^ capabilities) & capabilities);
> --> 1^0=1 & 0 = !0=1
> Which defaults a modem that fails to load capabilities as a cdma modem. Is
> there something I'm missing or just a bug? If it looks like just a bug let
> me know and I'll include a fix in the patch I'll be submitting shortly.

That was a bug when capabilities == 0; check the fix I pushed here:
https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=f137268ce12daaf56b79e508d6cba5e543feac36

Nice catch! :)

-- 
Aleksander
https://aleksander.es