[PATCH 13/14] zte, udev: avoid making the rules tty-only, and simplify single vendor check

Aleksander Morgado aleksander at aleksander.es
Wed Jul 27 22:14:07 UTC 2016


The rules were matched only against devices with an exact 'tty' subsystem, and
that means that we were not properly adding additional tags on e.g. wwan or
cdc-wdm devices.
---
 plugins/zte/77-mm-zte-port-types.rules | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/plugins/zte/77-mm-zte-port-types.rules b/plugins/zte/77-mm-zte-port-types.rules
index 027ad13..cae3cae 100644
--- a/plugins/zte/77-mm-zte-port-types.rules
+++ b/plugins/zte/77-mm-zte-port-types.rules
@@ -1,12 +1,8 @@
 # do not edit this file, it will be overwritten on update
 
 ACTION!="add|change|move", GOTO="mm_zte_port_types_end"
-SUBSYSTEM!="tty", GOTO="mm_zte_port_types_end"
-
-SUBSYSTEMS=="usb", ATTRS{idVendor}=="19d2", GOTO="mm_zte_port_types_vendorcheck"
-GOTO="mm_zte_port_types_end"
-
-LABEL="mm_zte_port_types_vendorcheck"
+SUBSYSTEMS!="usb", GOTO="mm_zte_port_types_end"
+ATTRS{idVendor}!="19d2", GOTO="mm_zte_port_types_end"
 
 ATTRS{idVendor}=="19d2", ATTRS{idProduct}=="0001", ATTRS{bInterfaceNumber}=="00", ENV{ID_MM_ZTE_PORT_TYPE_MODEM}="1"
 ATTRS{idVendor}=="19d2", ATTRS{idProduct}=="0001", ATTRS{bInterfaceNumber}=="02", ENV{ID_MM_ZTE_PORT_TYPE_AUX}="1"
-- 
2.9.0



More information about the ModemManager-devel mailing list