[PATCH 13/14] zte, udev: avoid making the rules tty-only, and simplify single vendor check

Dan Williams dcbw at redhat.com
Thu Jul 28 15:38:34 UTC 2016


On Thu, 2016-07-28 at 00:14 +0200, Aleksander Morgado wrote:
> The rules were matched only against devices with an exact 'tty'
> subsystem, and
> that means that we were not properly adding additional tags on e.g.
> wwan or
> cdc-wdm devices.
> 

Good catch, though perhaps we want to limit the PORT_TYPE tags to tty?
Maybe if ZTE re-uses IDs in the future we'd end up with a WDM port
conflict.

Dan

> ---
>  plugins/zte/77-mm-zte-port-types.rules | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/plugins/zte/77-mm-zte-port-types.rules b/plugins/zte/77-
> mm-zte-port-types.rules
> index 027ad13..cae3cae 100644
> --- a/plugins/zte/77-mm-zte-port-types.rules
> +++ b/plugins/zte/77-mm-zte-port-types.rules
> @@ -1,12 +1,8 @@
>  # do not edit this file, it will be overwritten on update
>  
>  ACTION!="add|change|move", GOTO="mm_zte_port_types_end"
> -SUBSYSTEM!="tty", GOTO="mm_zte_port_types_end"
> -
> -SUBSYSTEMS=="usb", ATTRS{idVendor}=="19d2",
> GOTO="mm_zte_port_types_vendorcheck"
> -GOTO="mm_zte_port_types_end"
> -
> -LABEL="mm_zte_port_types_vendorcheck"
> +SUBSYSTEMS!="usb", GOTO="mm_zte_port_types_end"
> +ATTRS{idVendor}!="19d2", GOTO="mm_zte_port_types_end"
>  
>  ATTRS{idVendor}=="19d2", ATTRS{idProduct}=="0001",
> ATTRS{bInterfaceNumber}=="00", ENV{ID_MM_ZTE_PORT_TYPE_MODEM}="1"
>  ATTRS{idVendor}=="19d2", ATTRS{idProduct}=="0001",
> ATTRS{bInterfaceNumber}=="02", ENV{ID_MM_ZTE_PORT_TYPE_AUX}="1"


More information about the ModemManager-devel mailing list