Fwd: Cinterion plugin patch

[matthew stanger]

Alexsander,

I'm traveling right now will test as soon as I get back tomorrow.

On Nov 24, 2016 2:58 AM, "Aleksander Morgado" <aleksander at aleksander.es>
wrote:

> Hey Matthew,
>
> On Wed, Nov 23, 2016 at 10:28 PM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
> > Great work! it looks really good now, although there are some small
> > things that could still be fixed. Let me prepare a branch with your
> > patch and I'll include some additional patches for you to review.
>
> Please check the 'stanger/cinterion' branch in the upstream git repository:
> https://cgit.freedesktop.org/ModemManager/ModemManager/log/
> ?h=stanger/cinterion
>
> I've included several changes that I suggested in previous reviews,
> like avoiding the enabling phase for the SWWAN feature support check,
> or the simpler ^SWWAN response parser. Let me know what you think, and
> please test the branch with a real device and let me know if you find
> any issue.
>
> BTW; I'm worried that we're binding the logic too much to a specific
> device with 2 interfaces; I've seen some online AT command reference
> that doesn't even talk about the third parameter to specify interface
> index in AT^SWWAN= set operations:
>   http://www.seapraha.cz/download/pls8-e_atc_v01000_tcm216-155309.pdf
> But for now I guess we're good.
>
> --
> Aleksander
> https://aleksander.es
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20161124/6a1e4dc5/attachment.html>