[review] dcbw/huawei-voice

Dan Williams dcbw at redhat.com
Mon Apr 17 17:08:20 UTC 2017


Hi,

Reworked the audio format stuff and added mmcli support.

Removed the 'blocked' stuff and started using 'connected' instead.

Now the larger change: call state handling in mm-base-call.c.  I
removed most of the base class call state setting for the MO (mobile-
originated, eg outgoing) call stuff.  I think the call state handling
there was wrong; only the subclasses know when the call is ringing and
has been picked up (answered) on the remote end through unsolicited
notifications.  So the subclasses must be the ones to update the call
state when they get these notifications, not the base call class. 
Huawei calls will now go through UNKNOWN -> DIALING -> RINGING_OUT ->
ACCEPTED, where previously they went UNKNOWN -> RINGING_OUT -> ACTIVE
and at the wrong times.

Eventually we should implement +CLCC (list current calls) polling in
the base class and then we can get this information generically for
subclasses that don't implement unsolicited notifications.  Newer
devices may have support for +CMCCS/+CMCCSI unsolicited notifications
which could also be used in a generic implementation.

Dan


More information about the ModemManager-devel mailing list