[PATCH 1/1] telit: fix #PSNT values interpretation for HSDPA and LTE modems

Daniele Palmas dnlplm at gmail.com
Fri Jun 16 14:12:39 UTC 2017


Telit LTE modems use #PSNT: 4 for LTE access technology,
and #PSNT: 5 for unknown access technology, while HSDPA
modems use #PSNT: 4 for unknown access technology.

This patch fixes those #PSNT values interpretation according
to the modem capabilities.
---
Hi,

this patch needs commit

58206664959a73deb8008b82b5070edb4ef87df2
helpers: extend +WS46=? response parser to support ranges

to work properly.

Thanks,
Daniele
---
 plugins/telit/mm-broadband-modem-telit.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c
index bd568a0..55deeed 100644
--- a/plugins/telit/mm-broadband-modem-telit.c
+++ b/plugins/telit/mm-broadband-modem-telit.c
@@ -954,8 +954,17 @@ response_processor_psnt_ignore_at_errors (MMBaseModem *self,
             *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_HSDPA);
             return TRUE;
         case 4:
-            *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_LTE);
+            if (mm_iface_modem_is_3gpp_lte (MM_IFACE_MODEM (self)))
+                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_LTE);
+            else
+                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN);
             return TRUE;
+        case 5:
+            if (mm_iface_modem_is_3gpp_lte (MM_IFACE_MODEM (self))) {
+                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN);
+                return TRUE;
+            }
+            /* Fall-through since #PSNT: 5 is not supported in other than lte modems */
         default:
             break;
         }
-- 
2.7.4



More information about the ModemManager-devel mailing list