[PATCH 1/1] telit: fix #PSNT values interpretation for HSDPA and LTE modems

[Aleksander Morgado]

On Fri, Jun 16, 2017 at 4:12 PM, Daniele Palmas <dnlplm at gmail.com> wrote:
> Telit LTE modems use #PSNT: 4 for LTE access technology,
> and #PSNT: 5 for unknown access technology, while HSDPA
> modems use #PSNT: 4 for unknown access technology.
>
> This patch fixes those #PSNT values interpretation according
> to the modem capabilities.
> ---
> Hi,
>
> this patch needs commit
>
> 58206664959a73deb8008b82b5070edb4ef87df2
> helpers: extend +WS46=? response parser to support ranges
>
> to work properly.
>
> Thanks,
> Daniele

Thanks, pushed to git master and mm-1-6. I also cherry picked commit
ab48dc5b17f90f12e82ccdd58a40d137858e1490 to mm-1-6, which was the one
introducing the "case 4".

> ---
>  plugins/telit/mm-broadband-modem-telit.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c
> index bd568a0..55deeed 100644
> --- a/plugins/telit/mm-broadband-modem-telit.c
> +++ b/plugins/telit/mm-broadband-modem-telit.c
> @@ -954,8 +954,17 @@ response_processor_psnt_ignore_at_errors (MMBaseModem *self,
>              *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_HSDPA);
>              return TRUE;
>          case 4:
> -            *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_LTE);
> +            if (mm_iface_modem_is_3gpp_lte (MM_IFACE_MODEM (self)))
> +                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_LTE);
> +            else
> +                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN);
>              return TRUE;
> +        case 5:
> +            if (mm_iface_modem_is_3gpp_lte (MM_IFACE_MODEM (self))) {
> +                *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN);
> +                return TRUE;
> +            }
> +            /* Fall-through since #PSNT: 5 is not supported in other than lte modems */
>          default:
>              break;
>          }
> --
> 2.7.4
>
> _______________________________________________
> ModemManager-devel mailing list
> ModemManager-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel



-- 
Aleksander
https://aleksander.es