[PATCH] telit: lock/unlock CSIM operations by default

Aleksander Morgado aleksander at aleksander.es
Wed Mar 15 09:28:26 UTC 2017


On Wed, Mar 15, 2017 at 2:40 AM, Dan Williams <dcbw at redhat.com> wrote:
>>
>> Can you guys review and test this patch? It looks like it solved the
>> issue I saw myself.
>>
>> The AT command reference for the Telit LE866 does say that the
>> AT+CSIM commands need to be enclosed within lock/unlock operations
>> like these.
>
> If the LOCK succeeds, then don't we need to UNLOCK if some intermediate
> step fails?  It looks like we'll just leave it in locked state if any
> step like say PIN or PIN2 calls
> load_unlock_retries_context_complete_and_free().

But all the other intermediate steps never fail; i.e.
csim_query_ready() always goes to the next step, never completes the
GSimpleAsyncResult. So effectively, if any intermediate AT command
fails, we just go on to the next one, and after the last one we have
the CSIM=0 to unlock.

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list