[PATCH] telit: lock/unlock CSIM operations by default

[Penalva, Salvador]

Hi all, 

I tried Aleksander Patch with an older version of telit HE910 FW and it works perfect. 

I just have one question, Is this CSIM command supported in all telit Modems? It wouldn't be good if by implementing this change on telit-plugin to fix this issue on telit HE910 and the other modems that can use this command, other modems  stop working.

Thank you,

Salvador

-----Original Message-----
From: Aleksander Morgado [mailto:aleksander at aleksander.es] 
Sent: miércoles, 15 de marzo de 2017 10:28
To: Dan Williams
Cc: Carlo Lobrano; Penalva, Salvador; Daniele Palmas; ModemManager (development)
Subject: Re: [PATCH] telit: lock/unlock CSIM operations by default

On Wed, Mar 15, 2017 at 2:40 AM, Dan Williams <dcbw at redhat.com> wrote:
>>
>> Can you guys review and test this patch? It looks like it solved the 
>> issue I saw myself.
>>
>> The AT command reference for the Telit LE866 does say that the
>> AT+CSIM commands need to be enclosed within lock/unlock operations
>> like these.
>
> If the LOCK succeeds, then don't we need to UNLOCK if some 
> intermediate step fails?  It looks like we'll just leave it in locked 
> state if any step like say PIN or PIN2 calls 
> load_unlock_retries_context_complete_and_free().

But all the other intermediate steps never fail; i.e.
csim_query_ready() always goes to the next step, never completes the GSimpleAsyncResult. So effectively, if any intermediate AT command fails, we just go on to the next one, and after the last one we have the CSIM=0 to unlock.

--
Aleksander
https://aleksander.es