[PATCH 1/2] broadband-modem, helpers: implement AT+WS46=? response parser

Aleksander Morgado aleksander at aleksander.es
Fri Mar 24 20:22:24 UTC 2017


On Fri, Mar 24, 2017 at 9:11 PM, Dan Williams <dcbw at redhat.com> wrote:
> On Sun, 2017-03-12 at 21:05 +0100, Aleksander Morgado wrote:
>> We want a parser that returns the full list of combinations found.
>
> Looks good to me except the comment:
>
> +    /* Fixup the ANY value, based on whether LTE is supported or not
>
> the code under that comment seems to use all modes, not just LTE/4G.

Ah, good catch, yes, first version of the patch was only for LTE and
then I updated it without updating the comment :) Will fix that before
merging.


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list