[PATCH 1/2] broadband-modem, helpers: implement AT+WS46=? response parser

Aleksander Morgado aleksander at aleksander.es
Fri Mar 24 20:31:56 UTC 2017


On Fri, Mar 24, 2017 at 9:22 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
>>> We want a parser that returns the full list of combinations found.
>>
>> Looks good to me except the comment:
>>
>> +    /* Fixup the ANY value, based on whether LTE is supported or not
>>
>> the code under that comment seems to use all modes, not just LTE/4G.
>
> Ah, good catch, yes, first version of the patch was only for LTE and
> then I updated it without updating the comment :) Will fix that before
> merging.

Pushed to git master after changing the comment text to:
/* Fixup the ANY value, based on which are the supported modes */


-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list