[PATCH 4/4] telit: remove custom +CMER enabling

[Aleksander Morgado]

On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado
<aleksander at aleksander.es> wrote:
> +    /* Our own enable now */
> +    mm_base_modem_at_command_full (
>          MM_BASE_MODEM (self),
>          mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self)),
> -        unsolicited_enable_sequence,
> -        NULL,  /* response_processor_context */
> -        NULL,  /* response_processor_context_free */
> -        NULL,  /* cancellable */
> -        callback,
> -        user_data);
> +        /* Enable +CIEV only for: signal, service, roam */
> +        "AT+CIND=0,1,1,0,0,0,1,0,0",
> +        5,
> +        FALSE,
> +        FALSE,
> +        NULL, /* cancellable */
> +        (GAsyncReadyCallback)cind_set_ready,
> +        task);

And now that I see this...
 * Shouldn't we enable +CIEV only for "signal" (that's the only thing
we end up parsing in the generic +CIEV parser)?
 * Shouldn't we move this setting to the generic broadband modem implementation?

-- 
Aleksander
https://aleksander.es