[PATCH 4/4] telit: remove custom +CMER enabling

[Dan Williams]

On Sun, 2017-05-21 at 15:41 +0200, Aleksander Morgado wrote:
> On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
> > +    /* Our own enable now */
> > +    mm_base_modem_at_command_full (
> >          MM_BASE_MODEM (self),
> >          mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self)),
> > -        unsolicited_enable_sequence,
> > -        NULL,  /* response_processor_context */
> > -        NULL,  /* response_processor_context_free */
> > -        NULL,  /* cancellable */
> > -        callback,
> > -        user_data);
> > +        /* Enable +CIEV only for: signal, service, roam */
> > +        "AT+CIND=0,1,1,0,0,0,1,0,0",
> > +        5,
> > +        FALSE,
> > +        FALSE,
> > +        NULL, /* cancellable */
> > +        (GAsyncReadyCallback)cind_set_ready,
> > +        task);
> 
> And now that I see this...
>  * Shouldn't we enable +CIEV only for "signal" (that's the only thing
> we end up parsing in the generic +CIEV parser)?
>  * Shouldn't we move this setting to the generic broadband modem
> implementation?

All three of these (signal, service, roam) are pretty standard.  Why
not move all of them to the generic implementation and make use of them
if we can?

Dan