Generic +CMER setting logic

[Carlo Lobrano]

Hey,

> Carlo, any chance you can make a quick test with these patches to see
> if they work as expected in the Telit modems? One of the changes I
> see is that the Telit plugin previously did the AT+CMER command only
> in the secondary port, while now we do it in both primary and
> secondary, not sure if that's an issue?

I guess the reason is that if the primary port is used for data
(i.e. PPPD) notification won't arrive or will be buffered, according
to the parameters passed to +CMER.

If we send +CMER in both ports, are we gonna receive URCs twice?

However, I'm not aware of any different behavior of Telit plugins
respect this case, so if it's fine for the other plugins, I think
it's ok for Telit one too.

I'll try the patch and keep you updated

On 21 May 2017 at 14:54, Aleksander Morgado <aleksander at aleksander.es>
wrote:

> Hey Dan, Carlo & everyone,
>
> This patch series implements the checking of the AT+CMER command
> parameters so that we can enable or disable them without error. The parser
> only checks the 'mode' (1st field) and 'ind' (4th field) settings, as those
> are the ones we request to update.
>
> Also modified the Cinterion and Telit plugins to avoid requiring custom
> AT+CMER settings (they had one because some devices didn't support ind=1,
> only ind=2). I've also seen the case where AT+CMER cannot even be disabled
> (mode=1 the only one allowed, as in the EM7345), and in that case we just
> skip the command.
>
> Carlo, any chance you can make a quick test with these patches to see if
> they work as expected in the Telit modems? One of the changes I see is that
> the Telit plugin previously did the AT+CMER command only in the secondary
> port, while now we do it in both primary and secondary, not sure if that's
> an issue?
>
> Cheers!
>
>     [PATCH 1/4] helpers: new 'AT+CMER=?' parser
>     [PATCH 2/4] broadband-modem: query +CMER format before
> enabling/disabling
>     [PATCH 3/4] cinterion: remove custom +CMER enabling
>     [PATCH 4/4] telit: remove custom +CMER enabling
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20170522/d9108ee2/attachment.html>